On the Golfers DVD, there are several movements that emphasis internal rotation of the shoulders.  Isn't this counterproductive for most people?  I'm not too familiar with golf, do they really need this even if they have upper cross syndrome?

Your observations are spot on and great. Internal and external rotation of the shoulders is provided as part of a comprehensive approach for golf performance training. During the swing the lead shoulder goes into internal rotation (backswing) and the other shoulder goes into external rotation (backswing) and then those actions reverse during downswing and follow through.  Addressing the upper cross syndrome and the tendency of the subscapularis to become tight and overdeveloped should be a consideration. Too much internal rotation can be problematic and the specific needs of the client should always be considered. The TRX Golf Workout provides an exercise library and the programs are suggestions and examples.  The TRX exercises should always be taught and performed with the appropriate scapular control and glenohumeral rhythm.

Please let me know if this helps.